ampproject / ampproject/amphtml

Migrate Component Unit tests to e2e tests

Open
#32,900 1 comment 0 reactions 0 assignees View on GitHub
Stale Type: Feature Request
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

## Describe the new feature or change to an existing feature you'd like to see

This feature is a migration of any unit tests which require external loading to an e2e format. In this way they break the unit test contract and would be better off as e2e tests.

This change would improve the code health of the amp repository, and improve the readability and understandability of these tests.

Changes would be required in the following components:
amp-3q-player
amp-a4a
doubleclick-sra
amp-apester-media
amp-brid-player
amp-connatix-player
amp-dailymotion
amp-delight-player
amp-gyfcat
amp-google-document-embed
amp-hulu
amp-imgur
amp-instagram
amp-izlesene
amp-jwplayer
amp-kaltura-player
amp-megaphone
amp-minute-media-player
amp-mowplayer
amp-nexxtv-player
amp-o2-player
amp-ooyala
amp-playbuzz
amp-powr-player
amp-reach-player
amp-redbull
amp-soundcloud
amp-springboard-player
amp-video-iframe
amp-vimeo
amp-vine
amp-vk
amp-wistia-player
amp-youtube

## Additional context

Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

Research direction

Start by locating the unit tests for the listed AMP components and identify which ones require external loading. Migrate those tests to the repository's e2e format, with completion shown by the affected components no longer relying on external loading in unit tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.