ampproject / ampproject/amphtml
Automatically sync visual-diff Chrome version with the used on Percy
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
We currently have to manually sync the server-side and CircleCI-side versions of Chrome when executing visual diff tests:
https://github.com/ampproject/amphtml/blob/3d0c39b3a45878dfc029f42c67a0782633440bcf/build-system/tasks/visual-diff/index.js#L60-L71
Ideally we could use the API to query for whatever version is currently being used on the server and fetch that one, instead of hard-coding the version post-upgrades
Contributor guide
Research direction
Start in build-system/tasks/visual-diff/index.js at lines 60-71 and review how the server-side and CircleCI Chrome versions are currently specified. Determine how to query Percy for its active Chrome version and use that value for visual-diff execution. Done means the versions no longer need to be synchronized manually after Percy upgrades.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100