ampproject / ampproject/amphtml
Bento: history support
Open
Stale
Type: Feature Request
WG: bento
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
One option:
1. Trivial cancelation-API-via-history provided via context. Falls back on `history.push` and `history.onpopstate`. This API is overridable for AMP to work via history service.
2. Navigation interceptor inside the popups (sidebar, lightbox, etc) to manage hash and document navigations to avoid break history state.
Contributor guide
Research direction
Start by comparing the two proposed approaches: a cancellable history API via context and navigation interceptors in popups such as the sidebar and lightbox. Determine the intended history behavior for hash and document navigation, then define how completion will be verified; no files or tests are named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, web-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100