ampproject / ampproject/amphtml
[amp-sidebar:1.0] Bento tracking issue
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
Open Tasks:
- [x] Initial Preact Component Outline - https://github.com/ampproject/amphtml/pull/31324
- [x] Implement animations for open and close
- [x] Imperative API
- [x] Initial AMP Component Outline - https://github.com/ampproject/amphtml/pull/31593
- [x] Customize colors in amp and bento - https://github.com/ampproject/amphtml/pull/31628
- [x] Port CSS and Mask
- [x] Warn when sidebar is not child of body - https://github.com/ampproject/amphtml/pull/31835
- [x] Check for RTL doc on sidebar - https://github.com/ampproject/amphtml/pull/31821
- [x] Background scrolling should be disabled when sidebar is opened - https://github.com/ampproject/amphtml/pull/32400
- [x] This should be updated once, chrome bug fix is in. See PR comments.
- [x] Animations can be updated mid-animation via APIs - https://github.com/ampproject/amphtml/pull/32584
- [x] Esc key should close the sidebar - https://github.com/ampproject/amphtml/pull/32431
- [x] Navigation Items / Toolbar
- [x] Add Portals https://github.com/ampproject/amphtml/pull/33213
- [x] Preact implementation + refactor so elements are always rendered https://github.com/ampproject/amphtml/pull/33244
- [x] Refactor design to be SSR compatible https://github.com/ampproject/amphtml/pull/34158
- [x] AMP implementation https://github.com/ampproject/amphtml/pull/34368
- [x] Explore refactoring so that elements are always rendered
- [x] How to handle focus when opening sidebar
- [x] ~Setup Gestures (swiping)~
- [x] Look into refactoring shared items with lightbox.
- [x] Manage history
- [ ] Add 1.0 to validator spec
Contributor guide
Assessment
This issue has not been assessed yet.