ampproject / ampproject/amphtml

[amp-story-player] Cannot update custom controls once set

Open
#31,338 5 comments 1 reaction 1 assignee Claimed by @gmajoulet View on GitHub
P1: High Priority Stale Type: Feature Request WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

## What's the issue?

Seems like once you define a custom control in the amp story player, you cannot update it. I'm reporting it as a bug because I think it's supposed to work

Some use cases: You may want to change the icon for a favorite button when you add it to favorites. You may want to hide/show buttons based on the story or page you are on.

## How do we reproduce the issue?

Change the JSON in the `application/json` script tag and controls do not update. Maybe there's some other API to update it?

```html


....


```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.