ampproject / ampproject/amphtml

Elaborate error message for amp-script with attribute data-ampdevmode

Open
#29,457 28 comments 0 reactions 1 assignee Assigned to @samouri View on GitHub
P3: When Possible Type: Bug WG: caching
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

In #27076, we made it legal to use `data-ampdevmode` on an `` component even if the attribute was not included on the root html node. An example:

```html

...

...

```

This approach works! However, it throws a validation error in the Chrome extension, even though it doesn't throw one in the Console:

`The attribute 'data-ampdevmode' in tag 'amp-script' is set to the invalid value ''.`

![image](https://user-images.githubusercontent.com/29419498/88311209-99997b00-ccde-11ea-95cd-611547444629.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.