ampproject / ampproject/amphtml
Convert Map/Set like structures/usages into actual Map/Set
Open
GFI Candidate
GFI Claimed!
P3: When Possible
Related to: Performance
Stale
Type: Feature Request
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
landing https://github.com/ampproject/amphtml/pull/26996 allows for us to use actual Map/Set.
We have places such as https://github.com/ampproject/amphtml/blob/master/src/utils/object.js#L30 which can be replaced by `Map`, and there are a lot of instances where we might be using an object or an array to mimic a `Set`.
We can do this on a case by case basis and we will need to know that there is no performance implications for the change.
I think this might be a good GFI for @xiexr151e
Contributor guide
Assessment
This issue has not been assessed yet.