ampproject / ampproject/amphtml

amp-inline-gallery throws an error if used within an amp-list

Open
#28,180 5 comments 0 reactions 1 assignee Claimed by @alanorozco View on GitHub
Stale Type: Bug WG: components
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

## What's the issue?
When trying to use `amp-inline-gallery` and `amp-base-carousel` within an `amp-list` template, an error is thrown for `getImpl is not a function`. This invalidates amp and doesn't render the thumbs, however it does still render the main carousel.

I'm raising this as an issue as our current solution uses `amp-carousel` within an `amp-list` without invalidating or any other issues. I was trying to update our current solution as it uses a separate amp-list for the thumbs.

This is my first issue report with AMP so please let me know if I need to do anything further or if you need a better explanation. Thanks.

![image](https://user-images.githubusercontent.com/44267427/80984587-f5620f80-8e25-11ea-9d78-4a055c0232f8.png)

## How do we reproduce the issue?
I've replicated a basic test case with vastly reduced data that will produce the error: https://codepen.io/RickRX/pen/YzyEdvw

## What browsers are affected?
All.

## Which AMP version is affected?
2004240001480

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.