ampproject / ampproject/amphtml

Story affiliate links always fire analytics events

Open
#28,171 1 comment 0 reactions 1 assignee Claimed by @gmajoulet View on GitHub
P3: When Possible Stale Type: Bug WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Re: https://github.com/ampproject/amphtml/pull/28128#discussion_r418746016

These tests always fail. It seems the analytics service is capturing the click and triggering the request before the affiliate link service calls stopPropagation. So, the analytics event always fires.

/cc @ampproject/wg-stories @estherkim

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.