ampproject / ampproject/amphtml

I2I Test to check for unnecessary network requests

Open
#26,754 6 comments 0 reactions 1 assignee Claimed by @rileyajones View on GitHub
P3: When Possible Related to: Flaky Tests Stale Type: Feature Request WG: infra
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Tests might be flaky because they implicitly relied on making external-facing requests. To counter this, we could run a dns logger while tests are being ran to ensure they are not making external-facing requests, except those in a whitelist.

Setting travis config to redirect `example.com` is insufficient because we cannot cover all possible domains.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.