ampproject / ampproject/amphtml
support custom coloring on amp-social-share SVG icon fills
- Dominant language
- JavaScript
- Stars
- 14.9k
- Forks
- 4.1k
- PR merge metrics
- No merged PRs in 30d
Description
According to https://amp.dev/documentation/examples/components/amp-social-share/?format=websites, icons colors can be styled using a css color attribute, same as the background-color attribute, however on the invoke of registerElement in amp-social-share-0.1.js the svg fill attribute of the default icons is fixed to '#fff' making the color attribute useless.
@paul-matthews
Contributor guide
Research direction
Start in amp-social-share-0.1.js at registerElement and inspect how the default SVG icons’ fill is set. Compare this with the amp-social-share documentation example’s color and background-color styling. Done means the color attribute can control the default icon fill instead of it remaining fixed at #fff.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100