ampproject / ampproject/amphtml

"A more real AMPHTML image ad" test flaky in INABOX_LITE experiment

Open
#24,421 6 comments 0 reactions 1 assignee Claimed by @lannka View on GitHub
P2: Soon Stale Type: Bug WG: monetization
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Integration tests in `test-amphtml-ads.js` are flaky on Headless Chrome in experiment B (INABOX_LITE):
```
DESCRIBE => A more real AMPHTML image ad
DESCRIBE => ATF within friendly frame or safe frame
DESCRIBE =>
IT => should properly render ad in a friendly iframe with viewability pings
✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

IT => should properly render ad in a safe frame with viewability pings
✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

DESCRIBE => No Host Script within friendly frame or safe frame
DESCRIBE =>
IT => should properly render ad in a friendly iframe with viewability pings
✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

IT => should properly render ad in a safe frame with viewability pings
✗ Error: Timeout of 15000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves.

[23:25:01] HeadlessChrome 76.0.3809 (Linux 0.0.0): Executed 266 of 440 (Skipped 174) 4 FAILED
```

Two flakes on master today.

https://travis-ci.org/ampproject/amphtml/builds/582846281
https://travis-ci.org/ampproject/amphtml/builds/582910186

/to @lannka

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.