ampproject / ampproject/amphtml

Inconsistent height selection for responsive ads between 3p/a4a/auto-ads

Open
#24,166 2 comments 0 reactions 0 assignees View on GitHub
Stale Type: Bug WG: monetization
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

In some places it's accidentally set to 300, I believe it should be consistently 500 everywhere.

I'm planning to fix this behind an experiment.

@lannka FYI

Contributor guide

Open the contributing guide

Research direction

Start by locating the responsive-ad height selection in the 3p, a4a, and auto-ads entry points, then compare where 300 and 500 are used. Check how the planned experiment controls the change. Done means the relevant paths consistently select 500, with the experiment behavior verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.