ampproject / ampproject/amphtml

amp-vimeo: Add support for unlisted videos

Open
#23,804 8 comments 0 reactions 1 assignee Claimed by @wassgha View on GitHub
Blocked Component: amp-vimeo Customer: DevRel P3: When Possible Stale Type: DevX Type: Feature Request WG: components
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

## Describe the new feature or change to an existing feature you'd like to see

Normal Vimeo URLs look like: `https://vimeo.com/172355597`

But Vimeo also has the ability to create unlisted videos: https://vimeo.com/blog/post/share-unlisted-videos-with-private-links/

Such unlisted video URLs look like: `https://vimeo.com/172355597/abcdef0123`

However, the `amp-vimeo` component has no way to supply the unlisted secret key. It only has a `data-videoid` attribute.

## Additional context

This issue was discovered as part of the AMP plugin for WordPress: https://github.com/ampproject/amp-wp/pull/2986

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.