ampproject / ampproject/amphtml

AMP4Email: Invalidate amp-lightbox and amp-image-lightbox

Open
#23,170 10 comments 1 reaction 0 assignees View on GitHub
INTENT TO DEPRECATE Stale WG: amp4email
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

amp-lightbox and amp-image-lightbox don't make much sense because they occupy the full height of the document (email) and don't change their appearance based on the vertical size of the outer page nor the scroll position of the outer page.

https://github.com/ampproject/amphtml/issues/22297 is one example of this.

We have come up with no good solutions to this problem and so Gmail thinks we should disable these two components because there's no good way to use them at the moment.

Contributor guide

Open the contributing guide

Research direction

Start by locating the AMP4Email handling for amp-lightbox and amp-image-lightbox, then review issue #22297 for the reported behavior. Determine how these two components should be invalidated in AMP4Email and identify the relevant tests; done means both are disabled there without changing their behavior in other contexts.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.