ampproject / ampproject/amphtml

Allow amp-iframe in amp-story-page-attachment

Open
#21,746 9 comments 0 reactions 1 assignee Claimed by @newmuis View on GitHub
P2: Soon Stale Type: Feature Request WG: caching WG: Caching: Triaged WG: stories
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

## Describe the new feature or change to an existing feature you'd like to see

amp-iframe appears to function as expected within an amp-story-page-attachment, but it doesn't pass validation.

An example use case would be to embed google maps in an attachment.

[validator-amp-story.protoascii#L708](https://github.com/ampproject/amphtml/blob/master/extensions/amp-story/validator-amp-story.protoascii#L708) mentions whitelisting as many components as possible, unless it results in bad UX or security issues. Do amp-iframes fall under either of those categories?

## Describe alternatives you've considered

For the map use case, you could probably generate map images and use amp-img but the experience is not the same as supporting a full blown map embed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.