ampproject / ampproject/amphtml

Add integration test for shadow dom

Open
#20,044 8 comments 1 reaction 0 assignees View on GitHub
P2: Soon Stale Type: Feature Request WG: performance
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

We've had multiple issues with DOM inconsistencies when AMP code is imported through a shadow dom based mechanism (in Polymer ), see list below. We need some shadow dom integration tests.

Here some of the issues:
#19434 amp-experiment
#19694 amp-subscriptions-google
#12912 amp-ads
#12388 amp-img
#12151 amp-list
#10799 amp-access

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the Polymer shadow DOM import mechanism and the referenced issues for amp-experiment, amp-subscriptions-google, amp-ads, amp-img, amp-list, and amp-access. Add integration coverage for AMP code imported through shadow DOM and verify the listed extensions behave consistently in that context.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.