ampproject / ampproject/amphtml

Remove `parseUrlDeprecated` from extensions

Open
#16,226 11 comments 0 reactions 1 assignee Claimed by @kevinkimball View on GitHub
P3: When Possible Stale Type: Bug WG: performance
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Sneaking in via `src/iframe-helper.js` and `src/3p-frame.js`.

Extensions affected: 3p (ads, twitter, facebook, etc.)

Initial attempt to fix: #16220

Problems possibly with trying to fetch service from a detached node:

`Error: [amp-a4a] Error: amp-a4a: adsense: The node must be attached to request ampdoc`

/cc @jridgewell @aghassemi

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.