ampproject / ampproject/amphtml

amp-bind-macro: Improve error message

Open
#12,469 2 comments 0 reactions 0 assignees View on GitHub
P3: When Possible Stale Type: Bug WG: runtime
Dominant language
JavaScript
Stars
14.9k
Forks
4.1k
PR merge metrics
No merged PRs in 30d

Description

Currently the error message for recursive/cyclic macros is something like `foo is not a supported function` *at invocation time* even though `foo()` may well exist. It'd be better to have a more precise error message *at parse time*.

/cc @josh313

Contributor guide

Open the contributing guide

Research direction

Start by locating the amp-bind-macro parsing and recursive/cyclic macro error handling, then compare where the current invocation-time message is produced with the parse-time path. Done means recursive or cyclic macros report a precise error during parsing instead of claiming an existing function is unsupported.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.