ampproject / ampproject/amp.dev

📖 AMP Stories documentation examples - incorrect/broken pages

Open
#5,401 3 comments 0 reactions 0 assignees View on GitHub
Category: Content Status: Pending Triage
Dominant language
HTML
Stars
600
Forks
675
PR merge metrics
No merged PRs in 30d

Description

## 📖 Missing or Out-of-Date Documentation

### Problem
Starting at the "Documentation > Examples" page for AMP Stories https://amp.dev/documentation/examples/?format=stories, under "Components", there are (only?) three components listed.

![amp-stories-examples-index](https://user-images.githubusercontent.com/54933393/108601860-c7d75a00-7396-11eb-8504-90f473d72d16.png)

- `amp-video`
- `amp-img`
- `amp-analytics`

Going to the first two components leads to the page having the left-hand sidebar specifically for "Stories", but the page content itself is identified as being for "Websites". As a result, that page is also not present in the left-hand sidebar at all.

![amp-stories-examples-amp-video](https://user-images.githubusercontent.com/54933393/108601785-55ff1080-7396-11eb-8d02-35f93ae117a9.png)

![amp-stories-examples-amp-img](https://user-images.githubusercontent.com/54933393/108601782-51d2f300-7396-11eb-96b7-dceacd4ccc37.png)

The page for `amp-analytics` lacks a sidebar altogether, and also appears quite broken with floating iframe bottom-right which also seems to contain broken content.

![amp-stories-examples-amp-analytics](https://user-images.githubusercontent.com/54933393/108601863-ce65d180-7396-11eb-866f-04e92cb2aeee.png)

### Location

* https://amp.dev/documentation/examples/?format=stories
* https://amp.dev/documentation/examples/components/amp-video/?format=stories
* https://amp.dev/documentation/examples/components/amp-img/?format=stories
* https://amp.dev/documentation/examples/components/amp-analytics/?format=stories

### Content type

Fundamentally, this probably requires a fix/rethink. Likely the component pages themselves need to also be marked as applying to Stories. Maybe some more components should also be listed from the index page? And whatever is happening there with `amp-analytics` should be fixed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.