ampproject / ampproject/amp.dev

Component importer should replace links to all imported files

Open
#2,645 0 comments 1 reaction 0 assignees View on GitHub
P2: Medium Type: Bug
Dominant language
HTML
Stars
600
Forks
675
PR merge metrics
No merged PRs in 30d

Description

Currently only links to component reference docs are converted to internal links on import.
But we also import some specific pages where the links are not changed.

We can use the import `spec.json` to map links to imported paths and rewrite matching links.

An example is the link `AMP.pushState()` here:
https://amp.dev/documentation/components/amp-bind/?format=websites#modifying-history-with-amp.pushstate()

Contributor guide

Open the contributing guide

Research direction

Start by locating the import spec.json and the importer that converts component reference links. Use the AMP pushState() example to trace how links to specific imported pages are handled. Done means matching links to all imported paths are rewritten as internal links, not only component reference documentation links.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
documentation
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.