ampproject / ampproject/amp-toolbox

IsValid rule not being used inside linter?

Open
#702 2 comments 0 reactions 0 assignees View on GitHub
toolbox-linter
Dominant language
HTML
Stars
459
Forks
242
PR merge metrics
No merged PRs in 30d

Description

Is there a particular reason why this rule isn't being run in the linter?
I feel like this is the most important rule to be run.

I also don't see an option that I can pass to add it to the list of rules to check against.

Contributor guide

Open the contributing guide

Research direction

Start by locating the linter entry point and the IsValid rule implementation. Check how the linter selects rules and whether an option can add IsValid to that list. Done means the rule is run by default or can be enabled through a documented option, with the reason for its current behavior clear.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.