ampproject / ampproject/amp-toolbox

<amp-story> Performance gains improvement update

Open
#1,316 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
459
Forks
242
PR merge metrics
No merged PRs in 30d

Description

Can the optimizer now handle the amp-story tag?

In this repo, it is mentioned that the amp-story tag is not supported:
https://github.com/ampproject/amp-toolbox/blob/e40c5c3461022209dd521518f873d41321670bf9/packages/optimizer/lib/Extensions.js#L27
https://github.com/ampproject/amp-toolbox/blob/e40c5c3461022209dd521518f873d41321670bf9/packages/optimizer/README.md?plain=1#L560

However, I think it can now be processed server side:

https://github.com/ampproject/amphtml/pull/37345
https://github.com/ampproject/amphtml/pull/37990
https://github.com/ampproject/amphtml/pull/37345/commits/8848d189e0123c2d9bf3b8ef8f02b23c320d4f33

Can amp-toolbox be updated to do all the boiler plate code removal for web stories?

Contributor guide

Open the contributing guide

Research direction

Start with the unsupported amp-story entry in packages/optimizer/lib/Extensions.js and the corresponding note in packages/optimizer/README.md. Read the linked AMP PRs and commit to determine which server-side processing is supported, then update the optimizer for the requested boilerplate removal and document the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
performance, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.