ampproject / ampproject/amp-toolbox-php
`<link preload>` is not inserted when using OptimizeHeroImages(PHP 5.6)
- Dominant language
- PHP
- Stars
- 74
- Forks
- 25
- Avg merge
- 1d 15h
- Merged PRs (30d)
- 3
Description
```
amp-toolbox-version : 0.11.0, 0.10.0, 0.6.0
PHP version : 5.6
```
`` may not be inserted when using `Transformer\OptimizeHeroImages` with ``.
I also use `Transformer\ServerSideRendering`.
Could you check this problem?
Contributor guide
No contributing guide indexed for this repository
Research direction
Reproduce the issue with PHP 5.6 using Transformer\OptimizeHeroImages and Transformer\ServerSideRendering on an amp-img data-hero input, starting from those transformer entry points. Compare the generated output across the listed amp-toolbox versions; done means the expected is inserted consistently when a hero image is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, performance
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100