ampproject / ampproject/amp-toolbox-php

Need to setup GitHub action to test amp script minification by the optional package Peast

Open
#315 0 comments 1 reaction 0 assignees View on GitHub
Minification Testing
Dominant language
PHP
Stars
74
Forks
25
Avg merge
1d 15h
Merged PRs (30d)
3

Description

To minify the amp scripts, we are using Peast as an optional package dependency. So the code related to minify the script is being ignored from the coverage report. This could be handled by a new GitHub action that include Peast before we generate the coverage report.

Related to https://github.com/ampproject/amp-toolbox-php/pull/281#discussion_r687502319

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the repository's existing GitHub Actions workflows and coverage-report setup first. Add a workflow step that installs the optional Peast package before coverage is generated, and consider the result done when the minification code is included in coverage without breaking the existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, php
Domain
ci-cd, testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.