amplication / amplication/amplication

🐛 Bug Report: @amplication/java-ast duplicates imports when references are used

Open
#9,845 3 comments 0 reactions 0 assignees View on GitHub
backend bug
Dominant language
TypeScript
Stars
16k
Forks
1.5k
PR merge metrics
No merged PRs in 30d

Description

### What happened?

When `References` are used in a `Class` (as happens automatically for annotations etc), the import statement is incorrectly duplicated.

You can see this in the [complex snapshot](https://github.com/amplication/ast-types/blob/cf559c32538c7eb5159868333e8bdc0c586230a0/libs/java-ast/tests/__snapshots__/ComplexExample.spec.ts.snap), which has several duplicated imports.

This is because the references are de-duplicated in a set, but javascript sets use reference equality.

I've got a fix, PR incoming.

### What you expected to happen

Repeat types in imports and references appear only once in the import list.

### How to reproduce

Run the snapshot test.

### Amplication version

@amplication/java-ast@0.0.2

### Environment

Node: v24.11.1
npm: 11.6.2

### Are you willing to submit PR?

Yes I am willing to submit a PR!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.