Provide a hook between resolve() and stream_socket_client() in DnsSocketConnector
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 269
- Forks
- 37
- PR merge metrics
- No merged PRs in 30d
Description
Follow up of https://github.com/symfony/symfony/pull/54179#discussion_r1514886587
Reading DnsSocketConnector, there is no easy way currently to hook between resolve() and stream_socket_client(). Providing a custom resolver doesn't help because of the inet_pton($host) shortcut.
Hooking here is useful for e.g. Symfony's NoPrivateNetworkHttpClient so that it can filter the remote host before trying to connect to it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading DnsSocketConnector and tracing the path from resolve() to stream_socket_client(), including the inet_pton($host) shortcut. Review the linked Symfony discussion for the intended interception point and determine what hook contract would let callers inspect the remote host before connection. Done means the hook is available without breaking custom resolver behavior and is covered by the relevant socket tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100