amphp/process 1.x on Windows: Trying to start a non-existent executable gets stuck forever
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 260
- Forks
- 29
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I couldn't find information anywhere whether the 1.x branch is still maintained. If it isn't, my apologies for bothering you.
I found that trying to start a non-existent executable using amphp/process 1.x gets stuck forever on Windows. Minimal example:
<?php
require "vendor/autoload.php";
use Amp\Process\Process;
use function Amp\Promise\wait;
$process = new Process("asdfasdf");
$pid = wait($process->start());
This seems to be a very similar problem to #51, and the patch proposed there (https://github.com/Nicodinus/amphp-process/commit/3d41ea5cf00b8cc5331b0fcf7bd27878cc72063a) fixes it for me.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal PHP example using Amp\Process\Process and Process::start(), then compare the behavior with the patch linked from issue #51. Reproduce the non-existent executable case on Windows and verify that start() completes with an appropriate failure instead of hanging indefinitely.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- backend, operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100