amphp / amphp/parallel

Ipc\connect is not part of the IpcHub interface

Open
#208 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
859
Forks
69
PR merge metrics
No merged PRs in 30d

Description

This essentially makes the entire IpcHub interface useless, as custom IPC implementations (i.e. IPC over FIFO, IPC over shared memory, et cetera) cannot override the logic of Ipc\connect() without also uselessly reimplementing the ProcessContextFactory and process-runner.php.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating IpcHub, Ipc\connect(), ProcessContextFactory, and process-runner.php, then trace how the current connection is selected. Check existing interface implementations and tests to understand the smallest change that lets custom IPC implementations supply their own connection without reimplementing process setup. Done means the relevant custom IPC path works and its tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.