MSVC installation issues
A pull request for this has already been merged.
- #8 by @aminya — merged
- Dominant language
- TypeScript
- Stars
- 276
- Forks
- 37
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 12
Description
This is now mostly fixed for VS2019 and VS2017. But still requires some more testing. The best way to fix it is to run the tests and debug the issues.
Old Description
Copied from https://github.com/jberezanski/ChocolateyPackages/issues/117
I am using visualstudio2017buildtools and visualstudio2019buildtools to set up MSVC. However, my tests fail because vcvars.bat cannot find the toolset.
https://github.com/aminya/setup-cpp
invalid parameters
[ERROR:vcvars.bat] Toolset directory for version '15.9' was not found.
[ERROR:VsDevCmd.bat] *** VsDevCmd.bat encountered errors. Environment may be incomplete and/or incorrect. ***
[ERROR:VsDevCmd.bat] In an uninitialized command prompt, please 'set VSCMD_DEBUG=[value]' and then re-run
[ERROR:VsDevCmd.bat] vsdevcmd.bat [args] for additional details.
[ERROR:VsDevCmd.bat] Where [value] is:
[ERROR:VsDevCmd.bat] 1 : basic debug logging
[ERROR:VsDevCmd.bat] 2 : detailed debug logging
[ERROR:VsDevCmd.bat] 3 : trace level logging. Redirection of output to a file when using this level is recommended.
[ERROR:VsDevCmd.bat] Example: set VSCMD_DEBUG=3
[ERROR:VsDevCmd.bat] vsdevcmd.bat > vsdevcmd.trace.txt 2>&1
https://github.com/aminya/setup-cpp/runs/3618796745?check_suite_focus=true#step:7:302
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/msvc/msvc.ts and run the existing tests for VS2017 and VS2019. Investigate the reported vcvars.bat and VsDevCmd.bat errors, including the missing 15.9 toolset, and use the linked run output for debugging. Done means the MSVC setup tests pass for the supported Visual Studio versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, github-actions, typescript
- Domain
- build-system, ci-cd, devops
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100