amethyst / amethyst/sheep

Named format uses `Vec<String>` instead of `&[String]`

Open
#13 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
Rust
Stars
93
Forks
12
PR merge metrics
No merged PRs in 30d

Description

Currently, `AmethystNamedFormat` takes extra options in the form `Vec`. This is suboptimal since it requires moving the whole container and cloning it if it needs to be reused. Instead it could be `&[String]`, or even `&[S]` with `AmethystNamedFormat where S: Deref`.

I'm happy to write up a PR for this if people think it's a good idea.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.