amethyst / amethyst/rendy

Stop using Either in render pass node

Open
#207 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
812
Forks
94
PR merge metrics
No merged PRs in 30d

Description

`Either` is used in render pass node for handling both images and surfaces:

https://github.com/amethyst/rendy/blob/778b47ff793d2fbf4f080f25e930b7402d0d8a01/graph/src/node/render/pass.rs#L30

However, this is simply confusing and does not provide much benefit considering it's an additional dependency as well. We should use a custom enum instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.