americanexpress / americanexpress/css-to-js

nodejs only, it seems

Open
#38 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
33
Forks
2
PR merge metrics
No merged PRs in 30d

Description

this convert function goes right into depending on path.basename which means it is nodejs only. your doc says in the first example, it takes a css string as one variant of param 1. that's what i am passing (a css string) but it is trying to load a file. 😢

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the convert function and inspect its use of path.basename, comparing that behavior with the first documentation example. Verify how a CSS string is distinguished from a file input. Done means the documented CSS-string form is converted without attempting to load it as a file, with coverage added for that input if the project has relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.