am-kantox / am-kantox/telemetria

Suggestion: move function id from event to metadata

Abierto
#26 1 comentario 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Elixir
Estrellas
26
Forks
3
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

The current implementation creates a new telemetry event for each profiled function. So if I want to pass gathered data further to telemetry.metrics (and view them as graphs in prometheus or something like it) I had to create a new metric for each profiled function.
I think it will be easier to use if all profiled functions will be gathered as a single event with function id included in the metadata.
This way I have to add only one distribution to telemetry.metrics to be able to view all profiled functions.
For example, if I will try to profile some function in the production environment currently I have to add detf to profiled function and new distribution to project Telemetry module. Thus I had to change and reload two modules instead of one.
If function id will be stored in event metadata, I won't have to change telemetry module to see the new profile graph.

I've implemented suggested changes in the forked branch: https://github.com/ludddd/telemetria for my own use.
If you find this idea useful I'll be glad to discuss how to integrate them back (maybe making them optional by flag?).

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.