alvr-org / alvr-org/ALVR

GetNextSwapTextureSetIndex incorrect code

Open
#3,239 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Rust
Stars
7.9k
Forks
708
Avg merge
3d 23h
Merged PRs (30d)
11

Description

`pIndices` might be uninitialized. Reported by @Vixea . The fix is not trivial due to the SteamVR API, so opening an issue instead.
https://github.com/alvr-org/ALVR/blob/1a4194ff137937c0a4f416ad2d6d1acedb851e8a/alvr/server_openvr/cpp/platform/win32/OvrDirectModeComponent.cpp#L145-L148

Should be replace to something like:
```C++
( *pIndices )[ i ] = ++pSet->unIndex % 3;
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.