alvarotrigo / alvarotrigo/pagePiling.js

Glitch in the navigation property of pagepiling function object.

Aperta
#160 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
4.1k
Fork
633
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

@alvarotrigo The ReadMe file says that,

![screenshot_20180808_022517](https://user-images.githubusercontent.com/42070051/43803821-5546e5b4-9ab3-11e8-82f1-92ada56855e9.png)

But if you make navigation property to true then nothing happens, as in the screen shot there is nothing in the right side of browser window,
![screenshot_20180808_023519](https://user-images.githubusercontent.com/42070051/43803926-baaa65f2-9ab3-11e8-8b1b-9a736466e930.png)

The reason is by setting the value of property to true you are making it a boolean in the first place which is not what is supposed to happen. you should pass in a empty object for that to work.
Secondly, the property is not false by default either(As written in ReadMe) coz of the lines of code in plugin,

![screenshot_20180808_000328](https://user-images.githubusercontent.com/42070051/43804027-197b94ac-9ab4-11e8-88dd-e71d3985f4f0.png)

This is checking if object is empty which is not by default in the default configurations object passed to pagepiling function.

Fixes:
1)Either ReadMe can be changed that navigation is by default true(I mean taking in object), not "programmatically true", and you must false it to remove the navigation in the right.
2)Or I have created a pull request which will correct the plugin to use the empty object by defaut(Not creating the navigation) and will create the navigation bar as properties passed to it.

Side-Note: `navigation:true` is never going to work, coz it contradicts the type of property. Only empty object will be taken up, if taken up.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.