alvarcarto / alvarcarto/url-to-pdf-api

Cookies not working – again (regression?)

オープン
#106 コメント 2 件 リアクション 0 件 担当者 0 名 GitHub で見る
PR welcome
主要言語
HTML
スター
7.1k
フォーク
779
PR マージ指標
30日以内にマージされた PR はありません

説明

If I read #83 correctly, it should have been merged into master already.

However, after I installed this package via git clone / npm install today, I get an error message in the console output when I try to render a page with a cookie:

```sh
# curl -o test.pdf -XPOST -d '{"url": "http://github.com", "cookies": [{ "name": "foo", "value": "bar" }]}' -H "Content-Type: application/json" http://localhost:9000/api/render
2019-05-06T10:54:08.359Z - info: [render-core.js] Rendering with opts: {
"cookies": [
{
"name": "foo",
"value": "bar"
}
],
"scrollPage": false,
"emulateScreenMedia": true,
"ignoreHttpsErrors": false,
"html": null,
"viewport": {
"width": 1600,
"height": 1200
},
"goto": {
"waitUntil": "networkidle2"
},
"output": "pdf",
"pdf": {
"format": "A4",
"printBackground": true
},
"screenshot": {
"type": "png",
"fullPage": true
},
"failEarly": false,
"url": "http://github.com"
}
2019-05-06T10:54:08.542Z - info: [render-core.js] Set browser viewport..
2019-05-06T10:54:08.543Z - info: [render-core.js] Emulate @media screen..
2019-05-06T10:54:08.544Z - info: [render-core.js] Setting cookies..
2019-05-06T10:54:08.623Z - error: [render-core.js] Error when rendering page: Error: Protocol error (Network.setCookies): Target closed.
2019-05-06T10:54:08.623Z - error: [render-core.js] Error: Protocol error (Network.setCookies): Target closed.
at Promise (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:202:56)
at new Promise ()
at CDPSession.send (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:201:12)
at Object.render (/home/tobi/Projects/url-to-pdf-api/src/core/render-core.js:90:20)
at process._tickCallback (internal/process/next_tick.js:68:7)
2019-05-06T10:54:08.623Z - info: [render-core.js] Closing browser..
2019-05-06T10:54:08.626Z - error: [error-logger.js] Request headers: host=localhost:9000, user-agent=curl/7.64.1, accept=*/*, content-type=application/json, content-length=76
2019-05-06T10:54:08.626Z - error: [error-logger.js] Request parameters:
2019-05-06T10:54:08.626Z - error: [error-logger.js] Request body: url=http://github.com, cookies=[name=foo, value=bar]
2019-05-06T10:54:08.626Z - error: [error-logger.js] { Error: Protocol error (Network.setCookies): Target closed.
at Promise (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:202:56)
at new Promise ()
at CDPSession.send (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:201:12)
at Object.render (/home/tobi/Projects/url-to-pdf-api/src/core/render-core.js:90:20)
at process._tickCallback (internal/process/next_tick.js:68:7)
message: 'Protocol error (Network.setCookies): Target closed.' } 'Error: Protocol error (Network.setCookies): Target closed.\n at Promise (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:202:56)\n at new Promise ()\n at CDPSession.send (/home/tobi/Projects/url-to-pdf-api/node_modules/puppeteer/lib/Connection.js:201:12)\n at Object.render (/home/tobi/Projects/url-to-pdf-api/src/core/render-core.js:90:20)\n at process._tickCallback (internal/process/next_tick.js:68:7)'
POST /api/render 500 268.897 ms - 88
```

Furthermore, the cookies do not come through at all when using GET:

```sh
# curl -o Downloads/test.pdf "http://localhost:9000/api/render?url=https://github.com&cookies[0][name]=foo&cookies[0][value]=bar"
2019-05-06T10:58:56.969Z - info: [render-core.js] Rendering with opts: {
"cookies": [],
"scrollPage": false,
"emulateScreenMedia": true,
"ignoreHttpsErrors": false,
"html": null,
"viewport": {
"width": 1600,
"height": 1200
},
"goto": {
"waitUntil": "networkidle2"
},
"output": "pdf",
"pdf": {
"format": "A4",
"printBackground": true,
"margin": {}
},
"screenshot": {
"type": "png",
"fullPage": true,
"clip": {}
},
"failEarly": false,
"url": "https://github.com"
}
```

Would be grateful for assistance or clarification.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。