alunduil / alunduil/blog.alunduil.com

Inverting the selection order as a duplication test

Open
#424 0 comments 0 reactions 0 assignees View on GitHub
idea
Dominant language
Astro
Stars
1
Forks
1
Avg merge
6h 34m
Merged PRs (30d)
118

Description

## Spark

Digest, week of 2026-07-25: the Genshin team builder learned to pick a weapon before a character, and the three component-consolidation issues closed the same day the feature shipped.

## Why it could be interesting

The feature and the refactor were the same job: inverting the selection order was only cheap because CharacterFilters and WeaponFilters had just collapsed into one FilterBar. The claim is that a UI inversion is a good forcing function for finding which of your components were secretly the same component — the feature request doubles as the duplication test.

## Open questions

- [ ] Did the consolidation land first and enable the inversion, or did the inversion reveal the duplication? Check the merge order.
- [ ] What broke in the mental model — does weapon-first make sense to a player, or only to the data model?
- [ ] How does the follow-up (explaining why an equipped weapon is unavailable) change the story? Inversion exposed a missing affordance.
- [ ] Is the elemental resonance work the same pattern again, or a different shape?

## Source material

- https://github.com/dungeon-studio/genshin.dungeon.studio/pull/1003 (closes #630)
- Consolidation closed 2026-07-31: https://github.com/dungeon-studio/genshin.dungeon.studio/issues/607, /609, /610
- Follow-up: https://github.com/dungeon-studio/genshin.dungeon.studio/issues/1024, https://github.com/dungeon-studio/genshin.dungeon.studio/issues/1030
- https://github.com/dungeon-studio/genshin.dungeon.studio/pull/1009 (closes #676), https://github.com/dungeon-studio/genshin.dungeon.studio/pull/1031
- Related: #252

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.