push hangs infinitely when is push_menu.push configured
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.9k
- Forks
- 164
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
the default keys for push are Pp (P => push menu, p => actual push). This works as it should.
But when you configure the push key binding like this:
push_menu.push = ["p"]
... then push hangs forever with any repo. There's no error message whatsoever. However, it still responds to the q key to quit.
The same behavior can be witnessed, when you configure any other key for push_menu.push. Also, the changed key binding is not being displayed in the menu, it shows p even if - say - f is configured.
It ONLY works, if you don't touch that setting.
best regards,
Tom
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the hang with push_menu.push = ["p"] and with another key, then compare it with the default Pp binding. Inspect the push_menu.push handling and menu display, and verify that configured bindings trigger push without hanging, quit still works, and the menu shows the configured key.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100