Better `quit` configuration
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2.9k
- Forks
- 164
- PR merge metrics
- No merged PRs in 30d
Description
Spawned from: https://github.com/altsem/gitu/issues/255
Relates to: https://github.com/altsem/gitu/issues/252
There's a lot of duplicated bindings config to quit menus. This was done as a workaround to keep other things simpler for a moment. There has to be a better way to specify this. A single binding?
root.quit = ["q", "<esc>"]
...
pull_menu.quit = ["q", "<esc>"]
...
push_menu.quit = ["q", "<esc>"]
...
rebase_menu.quit = ["q", "<esc>"]
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the duplicated quit bindings shown in this issue and the context in issues #255 and #252. Identify where menu configuration and inherited bindings are handled; done means defining quit behavior without repeating the same bindings across root, pull, push, and rebase menus.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, rust
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100