althonos / althonos/blanket

Use stricter paths when referring to items

Aperta
#14 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
26
Fork
3
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

https://github.com/althonos/blanket/blob/ce0b8ab848769680d2f290bf1d000c2dbbb29d8a/src/types/arc.rs#L11-L13

Just a couple small tips/recommendations:

It'd probably be better to use e.g. `::std::sync::Arc` instead of `std::sync::Arc` here (and likewise for all of the other types), otherwise the path refers to whatever is named `std` in the local scope (which isn't necessarily the `std` crate).

https://doc.rust-lang.org/reference/paths.html#path-qualifiers

Further these types should be pulled from `::core` else `::alloc` (if not found in core) as these crates are simply re-exported by `std` but have the additional benefit of being supported/accessible in `no_std` crates.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.