Consider removing _make_schema_call from WoodworkTableAccessor
- Ngôn ngữ chính
- Python
- Star
- 155
- Fork
- 24
- Chỉ số merge pull request
- Không có pull request nào được merge trong 30 ngày
Mô tả
As Woodwork development has progressed we have gradually been implementing more of the schema methods and properties on the WoodworkTableAccessor class. This is reducing the benefit of having `__getattr__` attempting to find methods on the Schema if they don't exist on the accessor.
As a side note, any methods or properties that we would like to document as part of the accessor class need to be implemented on that class.
In order to simplify and make sure methods and properties are documented where they should be, we might want to remove the `_make_schema_call` method completely from the table and directly implement the required properties and methods on the accessor class. This would also require updates to the `__getattr__` code and the associated tests.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.