alteryx / alteryx/woodwork

Series with PostalCode logical type can have `float` or `str` elements.

Open
#1,577 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
155
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Series with PostalCode logical type can have `float` or `str` elements.

For example,
```python
ser = pd.Series([12345, 67890]).astype('category')
ser = ww.init_series(ser, logical_type='PostalCode')
```
In the above code block, the elements of the series are floats, but in the following, they are strings:

```python
ser = pd.Series(["12345", "67890"]).astype('category')
ser = ww.init_series(ser, logical_type='PostalCode')
```

Both are valid initializations. We should decide whether we want to support both data types for the PostalCode logical type.

This issue was discussed here. https://github.com/alteryx/featuretools/pull/2365

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.