Parent nodes are not deduplicated
- Vorherrschende Sprache
- Haskell
- Sterne
- 98
- Forks
- 17
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
The node list is a set, so the semigroup instance automatically deduplicates. But the parents are stored as a list with cached size and after merges the list often contains duplicates. The worklist does get nubbed, so it is not catastrophic for performance, but I figured I'd mention it.
This discussion mentions nubbing the parent list as well, so it probably wasn't intentional? https://github.com/alt-romes/hegg/pull/13
Here is the relevant line:
https://github.com/alt-romes/hegg/blob/52c0143b217059f5686e45a2a4da03a8546bf205/src/Data/Equality/Graph.hs#L184
Edit: looked it up and seems like egg doesn't do it either. https://github.com/egraphs-good/egg/issues/113
Probably not crucial then, though it is a tad annoying that the graphviz graph shows them as duplicate nodes.
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Bewertung
Dieses Issue wurde noch nicht bewertet.