alshedivat / alshedivat/lola

LOLA Policy Gradient Target Computation

Ouverte
#8 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Jupyter Notebook
Étoiles
156
Forks
38
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Hello, thank you for open-sourcing the code! :-)
The code is really helpful in understanding the papers deeper.

I am interested in LOLA, especially its policy gradient method ([lola/train_pg.py](https://github.com/alshedivat/lola/blob/master/lola/train_pg.py)).
As mentioned in the paper, this implementation shows the actor-critic method.

However, I could not fully understand the target computation code:
`self.target = self.sample_return + self.next_v` ([code](https://github.com/alshedivat/lola/blob/master/lola/networks.py#L155)).
According to the [reference](http://incompleteideas.net/book/bookdraft2017nov5.pdf) (chapter 13, page 274, one-step actor-critic pseudocode), I wonder whether the target computation should use the step reward (i.e., reward at timestep t) instead of the return.

Thank you for your time and consideration!

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.