alphagov / alphagov/tech-docs-gem
Consider moving to CommonMark
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 16
- Forks
- 47
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 14
Description
Sounds like a plan re using our version 👍
That's fair - I think if it were me, I'd potentially be using this OpenAPI description with different tools (i.e. it may go onto the API Catalogue or other internal/external tooling, such as rendering inside tools like JIRA, or an IDE) and I'd be expecting a consistent formatting across all of those.
It's unlikely that many users will be affected, but the reason CommonMark became a thing is because so many Markdown flavours are inconsistent, so it's possible that people will be affected by quirks that RedCarpet has.
I agree that it'd be odd to write a doc page that doesn't render the same as the API docs, and to that I wonder if maybe we should look at using CommonMark everywhere?
Originally posted by @jamietanna in https://github.com/alphagov/tech-docs-gem/issues/281#issuecomment-966234478
Notes:
- GitHub previews won't necessarily match the site's view of content, so may make it less easy for folks just reviewing through GitHub
- Would require a SemVer major bump, as it would introduce chance of breakage, unless made opt-in
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names RedCarpet and CommonMark but no files or tests; start by locating the current Markdown renderer and reviewing issue 281. Compare the existing rendering behavior with CommonMark, then define the compatibility, opt-in or SemVer requirements before implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- markdown, ruby
- Domain
- documentation
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100