alpacahq / alpacahq/alpaca-trade-api-go

GetAssetsRequest.AssetClass should be type AssetClass (instead of string)

Open
#293 0 comments 1 reaction 0 assignees View on GitHub
v4
Dominant language
Go
Stars
429
Forks
118
PR merge metrics
No merged PRs in 30d

Description

There is already an [`AssetClass`](https://github.com/alpacahq/alpaca-trade-api-go/blob/7d20c8f30eaaf64619c4bd23b9855dd04dcccd35/alpaca/entities.go#L144) type, so it's just a matter of using it.

That is, change this:
```go
type GetAssetsRequest struct {
Status string
AssetClass string
Exchange string
}
```

To this:
```go
type GetAssetsRequest struct {
Status string
AssetClass AssetClass
Exchange string
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.