alpacahq / alpacahq/Momentum-Trading-Example

Infinite while loop

Open
#12 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
714
Forks
221
PR merge metrics
No merged PRs in 30d

Description

If the condition in this while loop ever evaluates to ```True```, it will always be ```True```.

current_dt and market_open never change wthin the while loop, which means that since_market_open will never change within the while loop. This means
```python
since_market_open.seconds // 60 <= 14
```
will never evaluate to ```False``` if it is intially ```True```

https://github.com/alpacahq/Momentum-Trading-Example/blob/be4352838eebdd2d124eedd341e31fbae8774f3d/algo.py#L392-L394

I believe it should be:

```python
while since_market_open.seconds // 60 <= 14:
time.sleep(1)
current_dt = datetime.today().astimezone(nyc)
since_market_open = current_dt - market_open
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.