alloy-rs / alloy-rs/alloy

[Bug] SendTransaction Failed on BSC due to Legacy TxType

Ouverte
#3,775 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Rust
Étoiles
1.3k
Forks
668
Merge moyen
2 j 2 h
PR mergées (30 j)
29

Description

### Component

provider, pubsub

### What version of Alloy are you on?

1.6.1

### Operating System

macOS (Apple Silicon)

### Describe the bug

In `provider/trait.rs`, function `estimate_eip1559_fees_with`, there is a condition to check if the latest block even has a base fee/supports EIP1559, it works for all evm chains which support eip1559 but fails on **Binance Smart Chain**. For BSC, although it does include `baseFeePerGas` in block headers and its RPC likely succeeds on EIP-1559 fee estimation calls, but it doesn't actually process EIP-1559 transaction types. If you call RPC something like "eth_getBlockByNumber", it returns a header that includes `baseFeePerGas` with "0x0" instead of None. So the condition check might fail with BSC, a small fix that additionally checks whether `baseFeePerGas` is non-zero might work well.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.