alloc / alloc/hattip-ws

`hattip-ws/uwebsockets` does not forward Hattip context to connected peers

Abierto
#1 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement
Lenguaje dominante
TypeScript
Estrellas
0
Forks
0
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I ran out of time to implement this, but if anyone's interested in contributing, take a look at how it's done in the `hattip-ws/node` adapter. The difficulty is that UWS (like Node) doesn't handle upgrade requests in a normal request handler, instead opting for a special, out-of-line handler. Also, unlike with Deno/Bun/Cloudflare, `crossws` wraps the UWS/Node request in a "proxy" object (presumedly for normalization), so the call to `forwardHattipContext` is less straight-forward.

Here's the `hattip-ws/node` implementation:

https://github.com/alloc/hattip-ws/blob/ef25ef7110ee2e5daf2f27496380348a70fc5f8e/src/adapters/node/node.ts#L41-L78

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.